AqBanking

This request is related to ticket https://bugs.kde.org/show_bug.cgi?id=512032 in the KMyMoney bug tracker.

Hi,

martin schrieb (#note-2):

Two thoughts:
- why would a user need to use a command line tool to find the settings folder?`It's always "$HOME/.aqbanking"?

Ah, okay, I see now, it's Windows.

Hi, thanks for the change.

I know it's outrageous of me to ask, but: Could the first patch be divided into one that adds the library and another which makes use of it?

The reason is that I'm using gwenbuild in my daily workflow with aqbanking and there are no changes in your patch for the 0BUILD files.

I can't apply the first patch directly because then I wouldn't be able to continue to work with gwenbuild unless I immediately created and adapted the 0BUILD files myself (and ATM I'd like to continue working in the workflow which works best for me, busy times now with CAMT, VOP and stuff).

Splitting that patch would allow me to first add the lib and then create and adapt the 0BUILD files later myself.

Regards
Martin

rhabacker schrieb (#note-4):
[...]

There is another possible improvement, namely to move this entry, which is contained in every command, to a macro, for example AB_CMD_HELP_ENTRY, and use this:

const GWEN_ARGS args[]= {
AB_CMD_HELP_ENTRY
};

[...]
Please don't move this just yet, as I started changing the way those arrays are created (see https://www.aquamaniac.de/rdm/projects/aqbanking/repository/aqbanking/revisions/master/entry/src/libs/plugins/backends/aqhbci/control/getaccsepa.c). That's how I define those arrays in one of my other larger projects and it makes them quite readable and short.

Regards
Martin

martin schrieb (#note-5):

The reason is that I'm using gwenbuild in my daily workflow with aqbanking and there are no changes in your patch for the 0BUILD files.

Here is an attempt to add such a file:

<?xml?>

<gwbuild>

  <target type="ConvenienceLibrary" name="aqcli" >

    <includes type="c" >
      $(gwenhywfar_cflags)
      -I$(topsrcdir)/src/libs
    </includes>

    <includes type="tm2" >
    </includes>

    <define name="BUILDING_AQBANKING" />
    <define name="AQBANKING_SYSCONF_DIR" value="$(aqbanking_cfg_searchdir)" quoted="TRUE" />

    <setVar name="local/cflags">$(visibility_cflags)</setVar>

    <setVar name="tm2flags" >
    </setVar>

    <setVar name="local/typefiles" >
    </setVar>

    <setVar name="local/built_sources" >
    </setVar>

    <setVar name="local/built_headers_pub">
    </setVar>

    <setVar name="local/built_headers_priv" >
    </setVar>

    <headers dist="true" >
      $(local/built_headers_pub)
      cli.h
    </headers>

    <sources>
      $(local/typefiles)
      cli.c
    </sources>

    <useTargets>
    </useTargets>

    <subdirs>
    </subdirs>

    <extradist>
    </extradist>

  </target>

but unfortunally with or without that file gwbuild was not able to build aqbanking, see https://www.aquamaniac.de/rdm/issues/326.

It appears that https://www.aquamaniac.de/rdm/attachments/615 has not been applied.

$ cd ~/src/aqbanking
$ grep -rn listConfDir
src/tools/aqbanking-cli/globals.h:146:int listConfDir(AB_BANKING *ab, GWEN_DB_NODE *dbArgs, int argc, char **argv);

rhabacker schrieb (#note-12):

It appears that https://www.aquamaniac.de/rdm/attachments/615 has not been applied.

[...]

You're right. The patch didn't apply cleanly, so I aborted it (I didn't have the time to work out what the problem was).

Regards
Martin

Okay, both remaining patches now applied to git. Thank you very much!

Regards,
Martin