Project

General

Profile

Bug #224

invalid pkg-config fields

Added by jasper about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
AqBanking
Start date:
09/14/2020
Due date:
Betriebssystem:
andere
AqBanking-Version:
6.2.2
Anwendung:
andere
Version der Anwendung:

Description

The installed pkg-config file contains two lines which are not well formed.

has-aqhbci
aqhbci-libraries

pkg-config doesn't recognize lines with hyphens as variables:

tau:2023 ~ % /usr/ports/pobj/pkgconfig-0.29.2/fake-amd64/usr/local/bin/pkg-config --debug --variable has-aqhbci aqbanking
Error printing enabled by default due to use of output options besides --exists, --atleast/exact/max-version or --list-all. Value of --silence-errors: 0
Error printing enabled
Adding virtual 'pkg-config' package to list of known packages
Looking for package 'aqbanking'
Looking for package 'aqbanking-uninstalled'
Reading 'aqbanking' from file '/usr/local/lib/pkgconfig/aqbanking.pc'
Parsing package file '/usr/local/lib/pkgconfig/aqbanking.pc'
  line>
  line>
  line>
  line>
  line>prefix=/usr/local
 Variable declaration, 'prefix' has value '/usr/local'
  line>exec_prefix=${prefix}
 Variable declaration, 'exec_prefix' has value '/usr/local'
  line>libdir=${exec_prefix}/lib
 Variable declaration, 'libdir' has value '/usr/local/lib'
  line>includedir=${prefix}/include
 Variable declaration, 'includedir' has value '/usr/local/include'
  line>pkgincludedir=${prefix}/include/aqbanking
 Variable declaration, 'pkgincludedir' has value '/usr/local/include/aqbanking'
  line>datarootdir=${prefix}/share
 Variable declaration, 'datarootdir' has value '/usr/local/share'
  line>datadir=${datarootdir}
 Variable declaration, 'datadir' has value '/usr/local/share'
  line>bindir=${exec_prefix}/bin
 Variable declaration, 'bindir' has value '/usr/local/bin'
  line>
  line>
  line>plugindir=${libdir}/aqbanking/plugins/44
 Variable declaration, 'plugindir' has value '/usr/local/lib/aqbanking/plugins/44'
  line>pkgdatadir=${datadir}/aqbanking
 Variable declaration, 'pkgdatadir' has value '/usr/local/share/aqbanking'
  line>all_includes=-I/usr/local/include/gwenhywfar5
 Variable declaration, 'all_includes' has value '-I/usr/local/include/gwenhywfar5'
  line>vmajor=6
 Variable declaration, 'vmajor' has value '6'
  line>vminor=2
 Variable declaration, 'vminor' has value '2'
  line>vpatchlevel=2
 Variable declaration, 'vpatchlevel' has value '2'
  line>vbuild=0
 Variable declaration, 'vbuild' has value '0'
  line>vtag=stable
 Variable declaration, 'vtag' has value 'stable'
  line>vstring=6.2.2
 Variable declaration, 'vstring' has value '6.2.2'
  line>
  line>
  line>aqbanking_libs=-L${libdir} -laqbanking
 Variable declaration, 'aqbanking_libs' has value '-L/usr/local/lib -laqbanking'
  line>aqbanking_includes=-I${includedir}/aqbanking6
 Variable declaration, 'aqbanking_includes' has value '-I/usr/local/include/aqbanking6'
  line>aqbanking_plugindir=${libdir}/aqbanking/plugins/44
 Variable declaration, 'aqbanking_plugindir' has value '/usr/local/lib/aqbanking/plugins/44'
  line>
  line>has-aqhbci=yes
  line>aqhbci-libraries=-L${libdir} -laqhbci
  line>
  line>
  line>Name: AqBanking
  line>
  line>Description: A library for online banking functions and financial data import/export
  line>
  line>Version: 6.2.2
  line>Libs: -L${libdir} -laqbanking
  line>Cflags: -I${includedir}/aqbanking6 -I/usr/local/include/gwenhywfar5
  line>
Path position of 'aqbanking' is 1
Adding 'aqbanking' to list of known packages

tau:2024 ~ % 

If I change those fields with s/-/_/g it works as expected:

tau:2025 ~ % /usr/ports/pobj/pkgconfig-0.29.2/fake-amd64/usr/local/bin/pkg-config --variable has_aqhbci aqbanking
yes
tau:2026 ~ % 

So the aqbanking.pc.in file can be fixed with a patch such as the one attached.
Additionally pkgconf also doesn't recognize this format.

patch-aqbanking_pc_in.txt Magnifier (530 Bytes) jasper, 09/14/2020 09:34 AM

History

#1 Updated by mlenk about 1 year ago

I'm not sure whether these variables are used anywhere at all. So I wonder whether instead of fixing them we should remove them.

What is your use case for querying pkg-config for these variables? Which project makes use of them?

Regards,
Micha

#2 Updated by jasper about 1 year ago

mlenk schrieb:

I'm not sure whether these variables are used anywhere at all. So I wonder whether instead of fixing them we should remove them.

What is your use case for querying pkg-config for these variables? Which project makes use of them?

Regards,
Micha

Hello Micha,

I don't have a use case for them, it was noticed in OpenBSD due to the strict parser of our pkg-config implementation which triggered on this particular file.
However looking at the code of the 6.2.2 release it seems the `aqbanking-config.in.in` does still reference these fields.

#3 Updated by mlenk about 1 year ago

  • Status changed from New to Resolved

I've removed the variables in commit 0712844567d4073d77b1149cb2c570861a723482.

#4 Updated by martin about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF