Project

General

Profile

Actions

Bug #278

closed

[PATCH] Guard unistd.h includes

Added by wrobelda over 3 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Category:
Gwenhywfar
Start date:
08/25/2022
Due date:
Betriebssystem:
Windows
AqBanking-Version:
5.10.1
Anwendung:
andere
Version der Anwendung:

Description

unistd.h is not available when building for windows natively


Files

Actions #1

Updated by martin over 3 years ago

  • Status changed from New to Feedback

Hmm, I'm unable to apply this patch to GIT master. Did you create those patches against a current master?

Actions #2

Updated by wrobelda over 3 years ago

Yeah, my bad, this was created after the patch I included here: https://www.aquamaniac.de/rdm/issues/282

Basically what it does is that it literally wraps all occurrences of #include <unistd.h> with HAVE_UNISTD_H guard

Actions #3

Updated by martin over 3 years ago

Yes, I understand what the patch does, its just that I can't apply it.

I don't understand why that is because the patch looks quite straightforward ...

Actions #4

Updated by wrobelda over 3 years ago

Some of the files it touches I had also previously modified in relation to string.h includes, hence the rejections. I have ~20 of these patches, which I kept adding to my local branch, but not all of them are actually inclusion-worthy, like the <strings.h> patch I discuss in that other issue.

Actions #5

Updated by martin about 1 month ago

  • Status changed from Feedback to Closed

No follow-up for a long time, closing. Please reopen if still relevant.

Actions

Also available in: Atom PDF