Projekt

Allgemein

Profil

Aktionen

Bug #278

offen

[PATCH] Guard unistd.h includes

Von wrobelda vor fast 3 Jahren hinzugefügt. Vor fast 3 Jahren aktualisiert.

Status:
Feedback
Priorität:
Normal
Kategorie:
Gwenhywfar
Beginn:
25.08.2022
Abgabedatum:
Betriebssystem:
Windows
AqBanking-Version:
5.10.1
Anwendung:
andere
Version der Anwendung:

Beschreibung

unistd.h is not available when building for windows natively


Dateien

Aktionen #1

Von martin vor fast 3 Jahren aktualisiert

  • Status wurde von New zu Feedback geändert

Hmm, I'm unable to apply this patch to GIT master. Did you create those patches against a current master?

Aktionen #2

Von wrobelda vor fast 3 Jahren aktualisiert

Yeah, my bad, this was created after the patch I included here: https://www.aquamaniac.de/rdm/issues/282

Basically what it does is that it literally wraps all occurrences of #include <unistd.h> with HAVE_UNISTD_H guard

Aktionen #3

Von martin vor fast 3 Jahren aktualisiert

Yes, I understand what the patch does, its just that I can't apply it.

I don't understand why that is because the patch looks quite straightforward ...

Aktionen #4

Von wrobelda vor fast 3 Jahren aktualisiert

Some of the files it touches I had also previously modified in relation to string.h includes, hence the rejections. I have ~20 of these patches, which I kept adding to my local branch, but not all of them are actually inclusion-worthy, like the <strings.h> patch I discuss in that other issue.

Aktionen

Auch abrufbar als: Atom PDF